Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

liana: 2.0 -> 4.0 #265182

Merged
merged 1 commit into from
Dec 20, 2023
Merged

liana: 2.0 -> 4.0 #265182

merged 1 commit into from
Dec 20, 2023

Conversation

dunxen
Copy link
Contributor

@dunxen dunxen commented Nov 3, 2023 •
edited
Loading

Description of changes

Diff: wizardsardine/liana@v2.0...v4.0

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Nov 3, 2023
@dunxen dunxen changed the title liana: 2.0 -> 3.0 liana: 2.0 -> 4.0 Dec 16, 2023
pbsds
pbsds reviewed Dec 18, 2023
View reviewed changes
Copy link
Member

@pbsds pbsds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Result of nixpkgs-review pr 265182 run on x86_64-linux 1

1 package built:
  • liana

Runs fine and LGTM, but please set meta.mainProgram

@dunxen
Copy link
Contributor Author

dunxen commented Dec 19, 2023

please set meta.mainProgram

Done and squashed.

Thanks for review!

@pbsds pbsds merged commit c2c09f5 into NixOS:master Dec 20, 2023
22 checks passed
@dunxen dunxen deleted the update-liana branch December 20, 2023 19:48
@github-actions GitHub Actions
Copy link
Contributor

Successfully created backport PR for release-23.11:

@github-actions github-actions bot mentioned this pull request May 16, 2024
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pbsds pbsds pbsds left review comments

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dunxen @pbsds