Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[23.11] certmgr-selfsigned: fix fetchpatch hash #272553

Merged
merged 1 commit into from
Dec 8, 2023

Conversation

pbsds
Copy link
Member

@pbsds pbsds commented Dec 6, 2023

Description of changes

certmgr and certmgr-selfsigned was merged during the bump from v1.6.4 to v3.0.3, but on 23.11 certmgr-selfsigned is left broken as noted in #271299 (comment).

Instead of bumping the version on 23.11 to v3.0.3, this PR fixes the hash of the patch applied.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@pbsds pbsds marked this pull request as ready for review December 6, 2023 22:03
@pbsds
Copy link
Member Author

pbsds commented Dec 6, 2023

please test @jcaesar: nix build github:nixos/nixpkgs/refs/pull/272553/head#certmgr-selfsigned

@pbsds pbsds changed the title certmgr-selfsigned: fetch fetchpatch hash certmgr-selfsigned: fix fetchpatch hash Dec 6, 2023
@pbsds
Copy link
Member Author

pbsds commented Dec 6, 2023

@ofborg build certmgr-selfsigned

@pbsds pbsds changed the title certmgr-selfsigned: fix fetchpatch hash [23.11] certmgr-selfsigned: fix fetchpatch hash Dec 6, 2023
@ofborg ofborg bot requested review from srhb and johanot December 6, 2023 23:30
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Dec 6, 2023
@pbsds pbsds merged commit 85ba693 into NixOS:release-23.11 Dec 8, 2023
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant