wireless-regdb: 2023.09.01 -> 2024.01.23

[trofi]

Changes: https://git.kernel.org/pub/scm/linux/kernel/git/wens/wireless-regdb.git/log/

Description of changes

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

---

Add a 👍 reaction to pull requests you find important.

[mweinelt]

Bisect thinks this change broke the check phase of crda. #286715

abe3cbb1c1e25b28e608cf79a9b62103db5d92dd is the first bad commit
commit abe3cbb1c1e25b28e608cf79a9b62103db5d92dd
Author: Sergei Trofimovich <slyich@gmail.com>
Date:   Sat Feb 3 15:40:35 2024 +0000

    wireless-regdb: 2023.09.01 -> 2024.01.23 (#286012)

 pkgs/data/misc/wireless-regdb/default.nix | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

crda> Running phase: checkPhase
crda> check flags: -j64 SHELL=/nix/store/cjbyb45nxiqidj95c4k1mh65azn1x896-bash-5.2-p21/bin/bash PREFIX=\$\(out\) SBINDIR=\$\(out\)/bin/ UDEV_RULE_DIR=\$\(out\)/lib/udev/rules.d/ REG_BIN=/nix/store/qx9xcsda4ypxfkg1x3s3ra1v6p38k6a5-wireless-regdb-2024.01.23/lib/crda/regulatory.bin VERBOSE=y verify
crda>   CHK  /nix/store/qx9xcsda4ypxfkg1x3s3ra1v6p38k6a5-wireless-regdb-2024.01.23/lib/crda/regulatory.bin
crda> Database signature verification failed.
crda> Invalid or empty regulatory file, note: a binary regulatory file should be used.
crda> make: *** [Makefile:161: verify] Error 234

[mweinelt]

Probably related to https://git.kernel.org/pub/scm/linux/kernel/git/wens/wireless-regdb.git/commit/?id=37dcea0e6e5effb4228fe385e906edba3cbee389

[trofi]

Yeah, let's revert until keys are sorted out. Proposed the revert as #286726

[trofi]

Sent the report upstream about new missing pubkey in crda side: https://lore.kernel.org/linux-wireless/ZcIXGjzrZrXPCBcp@nz.home/

While at it proposed the addition of crda to testsuite to have a better chance to catch it next time:

• wireless-regdb: add crda to tests #286730

[trofi]

Upstream responded that crda is not needed for kernels 4.16 and above (nixpkgs does not ship so old kernels).

Proposed a crda removal and wireless-regdb update as:

• crda: remove package, wireless-regdb: 2023.09.01 -> 2024.01.23 #286832