liboprf: init at 0.2.0 #291370
Open
liboprf: init at 0.2.0 #291370
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NixOSInfra
added
the
12. first-time contribution
ofborg
bot
added
10.rebuild-darwin: 0
|
I can't find any contributions, so I'm wondering why you'd add yourself to the maintainers list. Can you elaborate @Gepardgame? |
|
I thought I must first add me as a maintainer before contributing. |
You should add your package and add yourself to the maintainers list in the same PR :) |
ofborg
bot
added
8.has: package (new)
ofborg
bot
added
the
11.by: package-maintainer
github-actions
bot
added
the
8.has: maintainer-list (update)
FliegendeWurst
requested changes
Nov 2, 2024
| @@ -0,0 +1,31 @@ | |||
| { lib, fetchFromGitHub, stdenv, makeWrapper, libsodium }: | |||
There was a problem hiding this comment.
Please reformat with the new formatter.
Comment on lines
+25
to
+29
| meta = with lib; { | ||
| description = "liboprf - library providing OPRF and Threshold OPRF based on libsodium"; | ||
| homepage = "https://github.com/stef/liboprf"; | ||
| license = licenses.lgpl3; | ||
| maintainers = [ maintainers.gepardgame ]; |
There was a problem hiding this comment.
Suggested change
| meta = with lib; { | |
| description = "liboprf - library providing OPRF and Threshold OPRF based on libsodium"; | |
| homepage = "https://github.com/stef/liboprf"; | |
| license = licenses.lgpl3; | |
| maintainers = [ maintainers.gepardgame ]; | |
| meta = { | |
| description = "Library providing OPRF and Threshold OPRF based on libsodium"; | |
| homepage = "https://github.com/stef/liboprf"; | |
| license = lib.licenses.lgpl3; | |
| maintainers = [ lib.maintainers.gepardgame ]; |
Comment on lines
+21171
to
+21172
| # liboprf = callPackage ../development/libraries/liboprf { }; | ||
|
|
There was a problem hiding this comment.
Suggested change
| # liboprf = callPackage ../development/libraries/liboprf { }; |
wegank
added
the
2.status: merge conflict
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.