Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tuya-device-sharing-sdk: init at 0.2.0, home-assistant: update component-packages #294706

Merged
merged 3 commits into from
Mar 11, 2024

Conversation

aciceri
Copy link
Member

@aciceri aciceri commented Mar 10, 2024

Description of changes

The new tuya integration requires the python package tuya-device-sharing-sdk which is added by this PR.
Also I re-generated the component-packages.nix adding the previously missing propagated inputs for tuya and re-enabling tests for it. Also fixed minor typo in the script shebang (or I'm missing something? Without my change I couldn't run it but actually I find weird that nobody noticed in 1 year i.e. since when the supposed typo was introduced).

I tried building the new python package on my x86_64-linux workstation and then I also re-deployed my home-assistant (on an aarch64-linux host) using this branch and tuya seems to work now.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@aciceri aciceri changed the title tuya-device-sharing-sdk: init at 0.2.0 tuya-device-sharing-sdk: init at 0.2.0, home-assistant: update component-packages Mar 10, 2024
@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Mar 10, 2024
@aciceri aciceri marked this pull request as ready for review March 10, 2024 11:41
@aciceri aciceri requested a review from mweinelt as a code owner March 10, 2024 11:41
@mweinelt
Copy link
Member

Result of nixpkgs-review pr 294706 run on x86_64-linux 1

5 packages built:
  • home-assistant-component-tests.tuya
  • python311Packages.tuya-device-sharing-sdk
  • python311Packages.tuya-device-sharing-sdk.dist
  • python312Packages.tuya-device-sharing-sdk
  • python312Packages.tuya-device-sharing-sdk.dist

@mweinelt mweinelt merged commit 66f47bc into NixOS:master Mar 11, 2024
23 checks passed
@aciceri aciceri deleted the tuya branch March 11, 2024 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: python 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants