-
-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tuya-device-sharing-sdk: init at 0.2.0, home-assistant: update component-packages #294706
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aciceri
changed the title
tuya-device-sharing-sdk: init at 0.2.0
tuya-device-sharing-sdk: init at 0.2.0, home-assistant: update component-packages
Mar 10, 2024
ofborg
bot
added
8.has: package (new)
This PR adds a new package
11.by: package-maintainer
This PR was created by the maintainer of the package it changes
10.rebuild-darwin: 1-10
10.rebuild-linux: 1-10
labels
Mar 10, 2024
mweinelt
requested changes
Mar 10, 2024
pkgs/development/python-modules/tuya-device-sharing-sdk/default.nix
Outdated
Show resolved
Hide resolved
pkgs/development/python-modules/tuya-device-sharing-sdk/default.nix
Outdated
Show resolved
Hide resolved
mweinelt
reviewed
Mar 10, 2024
Result of 5 packages built:
|
mweinelt
approved these changes
Mar 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
6.topic: python
8.has: package (new)
This PR adds a new package
10.rebuild-darwin: 1-10
10.rebuild-linux: 1-10
11.by: package-maintainer
This PR was created by the maintainer of the package it changes
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
The new
tuya
integration requires the python packagetuya-device-sharing-sdk
which is added by this PR.Also I re-generated the
component-packages.nix
adding the previously missing propagated inputs fortuya
and re-enabling tests for it. Also fixed minor typo in the script shebang (or I'm missing something? Without my change I couldn't run it but actually I find weird that nobody noticed in 1 year i.e. since when the supposed typo was introduced).I tried building the new python package on my
x86_64-linux
workstation and then I also re-deployed my home-assistant (on anaarch64-linux
host) using this branch andtuya
seems to work now.Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.