Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[23.11] libfilezilla: 0.46.0 -> 0.47.0; filezilla: 3.66.5 -> 3.67.0 #304427

Merged
merged 2 commits into from
Apr 16, 2024

Conversation

vcunat
Copy link
Member

@vcunat vcunat commented Apr 16, 2024

Description of changes

Partial backport of PR #304354

Based on NEWS only the CVE is fixed by this.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

(cherry picked from commit 99ea322)
(cherry picked from commit a6677d9)
@vcunat vcunat added the 1.severity: security Issues which raise a security issue, or PRs that fix one label Apr 16, 2024
@vcunat
Copy link
Member Author

vcunat commented Apr 16, 2024

@ofborg build filezilla

@vcunat
Copy link
Member Author

vcunat commented Apr 16, 2024

Side note: it's weird that the nix expression for filezilla contains some darwin conditionals but sets platforms = platforms.linux;

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Apr 16, 2024
@vcunat vcunat merged commit c520a09 into NixOS:release-23.11 Apr 16, 2024
33 checks passed
@vcunat vcunat deleted the p/filezilla-backport branch April 16, 2024 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.severity: security Issues which raise a security issue, or PRs that fix one 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants