Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update hash for python bootstrap build #304879

Closed
wants to merge 1 commit into from

Conversation

cotrone
Copy link

@cotrone cotrone commented Apr 17, 2024

Description of changes

Updates the hash for the new version of pypa/build. Looks like it was missed in #294305.

Things done

Ran nix-prefetch-git https://github.com/pypa/build.git refs/tags/1.1.1 and replaced the hash with the new hash

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@mweinelt
Copy link
Member

Thanks for noticing. This is too big a rebuild for master, and also for staging-next at this time. It also needs validation, since build sits at the core of python packages, so I'm not sure if we should update, if it wasn't integration tested properly.

@mweinelt mweinelt marked this pull request as draft April 18, 2024 09:10
@tpwrules
Copy link
Contributor

Can the version number be reverted so the hash is not wrong?

@mweinelt
Copy link
Member

The src FOD is cached since the hash wasn't invalidated. We require another staging cycle to update it. The currently ongoing #305152 bumps build to 1.2.1.

@cotrone
Copy link
Author

cotrone commented Apr 22, 2024

Looks like this was fixed in #305152. Thanks!

@cotrone cotrone closed this Apr 22, 2024
@davean
Copy link

davean commented Apr 24, 2024

Thanks for noticing. This is too big a rebuild for master, and also for staging-next at this time. It also needs validation, since build sits at the core of python packages, so I'm not sure if we should update, if it wasn't integration tested properly.

This was a fairly big deal, is there any plans to protect from it happening again?

@jonringer
Copy link
Contributor

NixOS/rfcs#171 would have made this into a build failure

@jonringer
Copy link
Contributor

Be the FOD change you want to be

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants