Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python: add an error message for debugging infinite recursion #309477

Merged
merged 1 commit into from
May 10, 2024

Conversation

Atry
Copy link
Contributor

@Atry Atry commented May 6, 2024

Description of changes

This PR adds an error message to toPythonModule, which is useful for debugging infinite recursion like https://github.com/nix-community/poetry2nix/actions/runs/8962815004/job/24612240057

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 0 This PR does not cause any packages to rebuild labels May 6, 2024
@Atry Atry marked this pull request as ready for review May 6, 2024 08:58
@Atry Atry requested review from FRidh, jfly and Stunkymonkey May 6, 2024 09:00
@FRidh
Copy link
Member

FRidh commented May 6, 2024

That is a great improvement.

For context, this is an undocumented function. NixOS/nix#1609

@Atry
Copy link
Contributor Author

Atry commented May 6, 2024

@FRidh Do you have any concern merging this PR?

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label May 7, 2024
@Atry Atry requested review from cpcloud and mweinelt May 9, 2024 06:03
@Atry
Copy link
Contributor Author

Atry commented May 9, 2024

@mweinelt Do you want to merge this PR?

@mweinelt mweinelt merged commit d029669 into NixOS:master May 10, 2024
29 of 32 checks passed
@Atry Atry deleted the patch-4 branch May 10, 2024 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: python 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 0 This PR does not cause any packages to rebuild 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants