bcachefs-tools: patch to fix unlocking encrypted fs at boot with bcachefs-tools-1.7.0

[reedriley]

Fixes #309388

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

---

Add a 👍 reaction to pull requests you find important.

[JohnRTitor]

PR title should be "Patch to fix boot with encrypted root".

Result of nixpkgs-review pr 310504 run on x86_64-linux 1

1 package built:

• bcachefs-tools

[reedriley]

PR title should be "Patch to fix boot with encrypted root".

Nit? It's not restricted to the root fs - seems to be any unlocked at boot.

[JohnRTitor]

Good to go.

[onny]

Result of nixpkgs-review pr 310504 run on x86_64-linux 1

1 package built:

• bcachefs-tools

[onny]

Result of nixpkgs-review pr 310504 run on x86_64-linux 1

1 test built:

• nixosTests.bcachefs

[onny]

Thank you!

[pimeys]

Thank you. Tested this out today and it fixes the issue for me.

[JohnRTitor]

@reedriley recent kernel update to 6.9 broke this on unencrypted systems as well, including my own system.

As this patch was not working on bcachefs-tools master, I suspect this is because of that.

The upstream PR (koverstreet/bcachefs-tools#263) since then have been updated, and I would very much be supportive of testing it yourself and updating the patch on Nixpkgs. Ideally, the patch needs to be accepted on upstream first.

I had to run fsck from a NixOS ISO to fix this and then rebuild from there.

[reedriley]

@JohnRTitor I think I just hit the same breakage on upgrading myself...

But unless I'm mistaken bcachefs-tools builds off a tag where this patch does work, and that hasn't changed? And I upgraded from 6.9-rc6 to 6.9.1 which shouldn't have changed interactions here significantly? (In short - I'm confused. If I have time this weekend I'll see what happens if I revert my system's kernel to see if that helps...)