Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zig: refactor #314987

Merged
merged 6 commits into from
May 31, 2024
Merged

zig: refactor #314987

merged 6 commits into from
May 31, 2024

Conversation

AndersonTorres
Copy link
Member

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

- migrate it to a dedicated directory, zig/0.9
  - can't migrate to by-name
    - because of undecipherable darwin.apple_sdk_11_0.callPackage
- nixfmt
- add a simple version test
- migrate it to a dedicated directory, zig/0.10
  - can't migrate to by-name
    - because of undecipherable darwin.apple_sdk_11_0.callPackage
- nixfmt
- add a simple version test
- migrate it to a dedicated directory, zig/0.11
  - can't migrate to by-name
    - because of undecipherable darwin.apple_sdk_11_0.callPackage
- nixfmt
- add a simple version test
- migrate it to a dedicated directory, zig/0.12
  - can't migrate to by-name
    - because of undecipherable darwin.apple_sdk_11_0.callPackage
- nixfmt
- add a simple version test
@AndersonTorres AndersonTorres marked this pull request as ready for review May 29, 2024 09:37
@siraben
Copy link
Member

siraben commented May 30, 2024

Result of nixpkgs-review pr 314987 run on x86_64-linux 1

31 packages built:
  • backlight-auto
  • blackshades
  • cargo-lambda
  • cargo-zigbuild
  • clipbuzz
  • colorstorm
  • cyber
  • dt
  • findup
  • glsl_analyzer
  • linuxwave
  • mepo
  • minizign
  • ncdu
  • poop
  • river
  • river.man
  • rivercarro
  • tigerbeetle
  • waylock
  • zf
  • zig (zig_0_12)
  • zig.doc (zig_0_12.doc)
  • zig_0_10
  • zig_0_10.doc
  • zig_0_11
  • zig_0_11.doc
  • zig_0_9
  • zls
  • zon2nix
  • ztags

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/1702

@siraben siraben merged commit 5436273 into NixOS:master May 31, 2024
24 checks passed
@paparodeo
Copy link
Contributor

it looks like this PR may have broken the darwin builds using strictDeps. #314987

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants