-
-
Notifications
You must be signed in to change notification settings - Fork 14k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
zig: refactor #314987
Merged
Merged
zig: refactor #314987
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- migrate it to a dedicated directory, zig/0.9 - can't migrate to by-name - because of undecipherable darwin.apple_sdk_11_0.callPackage - nixfmt - add a simple version test
- migrate it to a dedicated directory, zig/0.10 - can't migrate to by-name - because of undecipherable darwin.apple_sdk_11_0.callPackage - nixfmt - add a simple version test
- migrate it to a dedicated directory, zig/0.11 - can't migrate to by-name - because of undecipherable darwin.apple_sdk_11_0.callPackage - nixfmt - add a simple version test
- migrate it to a dedicated directory, zig/0.12 - can't migrate to by-name - because of undecipherable darwin.apple_sdk_11_0.callPackage - nixfmt - add a simple version test
Result of 31 packages built:
|
siraben
approved these changes
May 30, 2024
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-already-reviewed/2617/1702 |
it looks like this PR may have broken the darwin builds using |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.