fetchYarnDeps: properly accept src argument #319623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Somehow this causes a rebuild of electron? |
|
Wild. I'll look into tracking down why it causes a rebuild later today. |
|
Oh I think I know why. It rebuilds because of the difference between |
Infinidoge
force-pushed
the
fix-fetch-yarn-deps
branch
from
abc5705
to
efff2ac
Compare
This would cause any drv to be rebuilt when any part of the default.nix changes. What we actually care about is the two JS files though, so simply reference them directly. Co-authored-by: Infinidoge <infinidoge@inx.moe>
Atemu
force-pushed
the
fix-fetch-yarn-deps
branch
from
a1e5c42
to
882cf18
Compare
|
Result of 2 packages marked as broken and skipped:
137 packages built:
|
Atemu
approved these changes
Jun 15, 2024
37 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
fetchYarnDepsis supposed to accept thesrc, argument, defaulting to unpacking and getting theyarn.lockfrom$src. However, after checking ifsrcexists for whether or not to run theunpackPhase, it dropssrcfrom the arguments, leading Nix to sayvariable $src or $srcs should point to the sourcedespite (supposedly) being passedsrc.This fixes that :)
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.