Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

netcoredbg: 3.0.0-1018 -> 3.1.0-1031 #329845

Merged
merged 1 commit into from
Aug 5, 2024
Merged

netcoredbg: 3.0.0-1018 -> 3.1.0-1031 #329845

merged 1 commit into from
Aug 5, 2024

Conversation

konradmalik
Copy link
Contributor

@konradmalik konradmalik commented Jul 25, 2024 •
edited
Loading

Description of changes

closes #329620

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@konradmalik konradmalik marked this pull request as ready for review July 25, 2024 08:15
@ofborg ofborg bot requested a review from leo60228 July 25, 2024 08:54
@konradmalik
Copy link
Contributor Author

Result of nixpkgs-review pr 329845 run on x86_64-darwin 1

1 package built:
  • netcoredbg

@konradmalik
Copy link
Contributor Author

Result of nixpkgs-review pr 329845 run on x86_64-linux 1

1 package built:
  • netcoredbg

@YoshiRulz
Copy link
Contributor

see also #326335

@YoshiRulz YoshiRulz added the 6.topic: dotnet Language: .NET label Jul 30, 2024
@konradmalik konradmalik mentioned this pull request Jul 30, 2024
Open
17 tasks
@konradmalik
Copy link
Contributor Author

@YoshiRulz thanks, commented there. This PR switches from dotnet 7 to dotnet 8

SuperSandro2000
SuperSandro2000 approved these changes Jul 30, 2024
View reviewed changes
Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, didn't test

@SchnozzleCat SchnozzleCat mentioned this pull request Aug 2, 2024
Closed
@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Aug 4, 2024
@tomberek tomberek merged commit f95279a into NixOS:master Aug 5, 2024
42 checks passed
@tomberek
Copy link
Contributor

tomberek commented Aug 5, 2024

Result of nixpkgs-review pr 329845 run on x86_64-linux 1

1 package built:
  • netcoredbg

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 approved these changes

@leo60228 leo60228 Awaiting requested review from leo60228

Assignees
No one assigned
Labels
6.topic: dotnet Language: .NET 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update request: netcoredbg 3.0.0-1018 → 3.1.0-1031
5 participants
@konradmalik @YoshiRulz @tomberek @SuperSandro2000 @wegank