Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

home-assistant-custom-components.somweb: init at 1.1.0 #332967

Merged
merged 2 commits into from
Aug 20, 2024

Conversation

uvNikita
Copy link
Contributor

@uvNikita uvNikita commented Aug 7, 2024

Description of changes

  • home-assistant-custom-components.somweb: init at 1.1.0
  • python3Packages.somweb: init at 1.2.1

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@uvNikita
Copy link
Contributor Author

uvNikita commented Aug 7, 2024

Rebased:

  • added mainProgram
  • added doCheck = false
  • reformatted pkgs/servers/home-assistant/custom-components/somweb/default.nix file

Also created issue in the component repository to clarify the license.

@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Aug 7, 2024
@uvNikita
Copy link
Contributor Author

@mweinelt MIT license was added to the repository 🥳

@uvNikita
Copy link
Contributor Author

Rebased:

  • changed from propagatedBuildInputs to dependencies.

I think this should be ready now.

@mweinelt mweinelt merged commit ed74e3c into NixOS:master Aug 20, 2024
24 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: python 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants