-
-
Notifications
You must be signed in to change notification settings - Fork 13.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
German Dictionary for Hunspell #36155
Conversation
This PR would introduce |
cc @Fuuzetsu |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's ok with me the way it is in this PR.
@GrahamcOfBorg build hunspellDicts.de-de ispell |
Failure on x86_64-darwin (full log) Partial log (click to expand)
|
Success on x86_64-linux (full log) Partial log (click to expand)
|
Success on aarch64-linux (full log) Partial log (click to expand)
|
pkgs/tools/text/ispell/default.nix
Outdated
#sed -i -e 's| *extern int\s*strcmp.*||' ijoin.c | ||
|
||
#XXX: buildhash uses int to store pointers, which doesn't work on 64bit | ||
#sed -i -e 's|\s*int\s*strptr|intptr_t strptr|' -e 's|\s*int\s*x|intptr_t x|' buildhash.c |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should these be removed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed them.
Note that this relies on ispell as a dependency. Also, perl and hunspell itself are used during building the dictionary.
{ stdenv, fetchurl, bison, ncurses }: | ||
|
||
stdenv.mkDerivation rec { | ||
name = "ispell-3.3.02"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is outdated, current version is 3.4.00: https://www.cs.hmc.edu/~geoff/ispell.html
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. The reason why I did not try to use the newest one is that ispell here is only used as a build dependency for the dictionary. So I basically stuck to the version that someone else deemed working.
This was added only to build hunspellDicts.de_DE: [1] The patches came from an older PR (taken from Debian): [2] but aren't needed to build the dictionary. [1]: NixOS#36155 [2]: NixOS#3320
Motivation for this change
Add german dictionary to hunspell.
Things done
Building these dicts needs ispell, so I re-used the PR #3320 for that.
For the actual dict, used the code from this: #32777
Tested by building hunspell with german and en-US dictionaries on 17.09 and master and running
hunspell -D
, which then shows the german dictionary. Also tested actual spelling correction, which gives the same result as the online spell checker (https://j3e.de/cgi-bin/spellchecker)build-use-sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)