haskell infra: Use splicing like normal callPackage
#43264
Conversation
Otherwise extra packages in scope can't be made to work for cross. As much as I think splicing is an evil trick, I think it's best to do this and at least have it work consistently for now. It would seems simpler to expose a `newScopeWithSplicing`, but there's a few attrs (like `buildPackages` or `buildHaskellPackages`) that shouldn't be spliced. Users should instead splice, override the splicing on those packages, and apply `newScope` to that.
| pkgsHostHost = {}; | ||
| pkgsHostTarget = scope; | ||
| pkgsTargetTarget = {}; | ||
| } // { |
There was a problem hiding this comment.
Maybe add a parenthesis around pkgs.splicePackages {...} to make it more clear. I think that's how the precedence works but it is sometimes unclear whether this is (pkgs.splicePackages {...}) // {...} or pkgs.splicePackages ({...} // {...})
There was a problem hiding this comment.
Maybe it's just all the Haskell, but I find function application before operators one of the few precedence rules I do remember 😁.
These should all come from `buildHaskellPackages`
GrahamcOfBorg
added
10.rebuild-darwin: 0
|
And because of all the problems with max args lately, let me say this preserves hashes in the native case and thus is fine. |
|
Cool! So, does it mean that my concerns about |
|
@kirelagin hehe not quite! https://github.com/NixOS/nixpkgs/blob/master/pkgs/development/haskell-modules/make-package-set.nix#L111 prevents splicing on |
|
Errr and what is the purpose of preventing splicing on |
|
Because it already functions as the If every package used the actual |
Motivation for this change
This ensures all tools and
setup-dependsare drawn frombuildHaskellPackages, the equivalent ofbuildPackages, so that they run on the build system as intended.Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)CC @kirelagin