Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

haskell: friday: jailbreak #53432

Merged
merged 1 commit into from
Jan 5, 2019
Merged

haskell: friday: jailbreak #53432

merged 1 commit into from
Jan 5, 2019

Conversation

jerith666
Copy link
Contributor

Motivation for this change

broken by recent haskell updates

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg GrahamcOfBorg added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 0 This PR does not cause any packages to rebuild labels Jan 5, 2019
ryantm
ryantm requested changes Jan 5, 2019
View reviewed changes
Copy link
Member

@ryantm ryantm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change the commit message to be haskellPackages.friday: jailbreak; this will allow automated infrastructure to check the work more easily.

@ryantm
Copy link
Member

ryantm commented Jan 5, 2019

@GrahamcOfBorg build haskellPackages.friday

peti
peti requested changes Jan 5, 2019
View reviewed changes
Copy link
Member

@peti peti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please report this issue upstream and add a link to the upstream ticket into the file.

@jerith666 jerith666 mentioned this pull request Jan 5, 2019
Closed
@jerith666
Copy link
Contributor Author

Done and done! :)

@ryantm ryantm merged commit d637039 into NixOS:master Jan 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peti peti peti requested changes

@ryantm ryantm ryantm requested changes

@basvandijk basvandijk Awaiting requested review from basvandijk

Assignees
No one assigned
Labels
6.topic: haskell 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 0 This PR does not cause any packages to rebuild
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jerith666 @ryantm @peti @GrahamcOfBorg