Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ninja: make reproducible #55421

Merged
merged 2 commits into from
Feb 8, 2019
Merged

ninja: make reproducible #55421

merged 2 commits into from
Feb 8, 2019

Conversation

grahamc
Copy link
Member

@grahamc grahamc commented Feb 7, 2019

See ninja-build/ninja#1529

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@matthewbauer
Copy link
Member

Could we set generate.consistent.ids globally?

@grahamc
Copy link
Member Author

grahamc commented Feb 7, 2019

Probably not a nice idea, for one it doesn't produce good IDs. Secondly, this is only fixing a bug in ninja's own docs generation. For our own docs, I think it is preferable to have the unstable IDs to push us to making actually decent IDs.

@GrahamcOfBorg GrahamcOfBorg added the 10.rebuild-darwin-stdenv This PR causes stdenv to rebuild label Feb 7, 2019
@grahamc grahamc changed the base branch from master to staging February 7, 2019 23:05
@GrahamcOfBorg GrahamcOfBorg added 6.topic: rust 6.topic: stdenv Standard environment 6.topic: vim 8.has: changelog 8.has: documentation 8.has: module (update) This PR changes an existing module in `nixos/` 2.status: merge conflict This PR has merge conflicts with the target branch and removed 6.topic: GNOME GNOME desktop environment and its underlying platform 6.topic: golang 6.topic: haskell 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: pantheon The Pantheon desktop environment 6.topic: printing 6.topic: python 6.topic: qt/kde 6.topic: rust 6.topic: stdenv Standard environment 6.topic: vim 8.has: changelog 8.has: documentation 8.has: module (update) This PR changes an existing module in `nixos/` 2.status: merge conflict This PR has merge conflicts with the target branch labels Feb 7, 2019
@worldofpeace @grahamc
ninja: Add comment explaining the consistent ID patch
3abe344 
Co-Authored-By: grahamc <graham@grahamc.com>
@domenkozar domenkozar merged commit 9bffdaa into NixOS:staging Feb 8, 2019
@grahamc grahamc deleted the ninjarepro branch February 8, 2019 12:38
@grahamc
Copy link
Member Author

grahamc commented Oct 29, 2020 •
edited
Loading

12:29 gchristensen: do you still agree with #55421 (comment), considering it's been over a year and 2 of the 20 broken packages on r13y.com are Nix and the Nix manual?
12:29 *NixOS manual
12:30 well...yes, because the IDs are really bad. I'd rather a build-time test that looks for bad IDs and fails
12:30 following the principle of https://www.w3.org/Provider/Style/URI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace left review comments

@orivej orivej orivej approved these changes

@thoughtpolice thoughtpolice Awaiting requested review from thoughtpolice

@bjornfor bjornfor Awaiting requested review from bjornfor

Assignees
No one assigned
Labels
10.rebuild-darwin: 501+ 10.rebuild-darwin: 5001+ 10.rebuild-darwin-stdenv This PR causes stdenv to rebuild 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@grahamc @matthewbauer @orivej @worldofpeace @domenkozar @GrahamcOfBorg