-
-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
meson: enable auto_features by default #63493
Conversation
e201510
to
a16fcde
Compare
Oops, wrong syntax. |
Evaluation compared to one from a jobset building a commit this PR is based on: https://hydra.nixos.org/eval/1526405?compare=1525113 |
The failures are fewer than I expected. Perhaps more will show up once we fix the libs.
|
Pushed the fixes, time for round two. Did not rebase yet so that we could have clearer picture which failures are caused by this and which by something else. Also, I will be leaving for a month of mostly-offline vacation without a PC soon, so feel free to finish this in my absence. |
Sounds good 👍 I can finish this. |
4fa40c5
to
1880edc
Compare
1880edc
to
e64a975
Compare
We disabled them by default when they were introduced in NixOS#42994 but enabling them probably makes more sense: NixOS#54398 NixOS#63491
This should allow us to inherit optimization/striping from stdenv
Meson setup hook now defaults to this.
Also split multiple outputs and enable tests.
It is now default
It is now the default.
It is now the default.
It is now the default.
e64a975
to
ac404cf
Compare
This comment has been minimized.
This comment has been minimized.
This pull request has been mentioned on Nix community. There might be relevant details there: https://discourse.nixos.org/t/psa-meson-now-building-all-auto-detected-features/3271/1 |
We disabled them by default when they were introduced in
#42994
but enabling them probably makes more sense:
#54398
#63491
We will probably need to adjust dependencies like in #63491 all over the place.