Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

meson: enable auto_features by default #63493

Merged
merged 14 commits into from
Jun 25, 2019

Conversation

jtojnar
Copy link
Member

@jtojnar jtojnar commented Jun 19, 2019

We disabled them by default when they were introduced in

#42994

but enabling them probably makes more sense:

#54398
#63491

We will probably need to adjust dependencies like in #63491 all over the place.

@jtojnar
Copy link
Member Author

jtojnar commented Jun 19, 2019

Oops, wrong syntax.

@grahamc
Copy link
Member

grahamc commented Jun 20, 2019

Jobset created: https://hydra.nixos.org/jobset/nixpkgs/pr-63493-meson-auto-features

@jtojnar
Copy link
Member Author

jtojnar commented Jun 20, 2019

Evaluation compared to one from a jobset building a commit this PR is based on: https://hydra.nixos.org/eval/1526405?compare=1525113

@jtojnar
Copy link
Member Author

jtojnar commented Jun 24, 2019

@jtojnar
Copy link
Member Author

jtojnar commented Jun 24, 2019

Pushed the fixes, time for round two. Did not rebase yet so that we could have clearer picture which failures are caused by this and which by something else.

Also, I will be leaving for a month of mostly-offline vacation without a PC soon, so feel free to finish this in my absence.

@ofborg ofborg bot added 6.topic: GNOME GNOME desktop environment and its underlying platform 2.status: merge conflict This PR has merge conflicts with the target branch labels Jun 24, 2019
@worldofpeace
Copy link
Contributor

Pushed the fixes, time for round two. Did not rebase yet so that we could have clearer picture which failures are caused by this and which by something else.

Also, I will be leaving for a month of mostly-offline vacation without a PC soon, so feel free to finish this in my absence.

Sounds good 👍 I can finish this.

@worldofpeace worldofpeace self-assigned this Jun 24, 2019
@ofborg ofborg bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Jun 25, 2019
@worldofpeace worldofpeace merged commit 94e8afc into NixOS:staging Jun 25, 2019
@jtojnar jtojnar deleted the meson-auto-features branch June 25, 2019 16:49
@worldofpeace

This comment has been minimized.

@nixos-discourse
Copy link

This pull request has been mentioned on Nix community. There might be relevant details there:

https://discourse.nixos.org/t/psa-meson-now-building-all-auto-detected-features/3271/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants