Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

home-assistant: add override for pyowm #91273

Merged
merged 1 commit into from
Jun 23, 2020
Merged

home-assistant: add override for pyowm #91273

merged 1 commit into from
Jun 23, 2020

Conversation

Mic92
Copy link
Member

@Mic92 Mic92 commented Jun 22, 2020 •
edited
Loading

3.0 is not compatible with home-assistant

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Mic92
home-assistant: add override for pyowm
aac8f45 
3.0 is not compatible with home-assistant
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Jun 22, 2020
mweinelt
mweinelt approved these changes Jun 22, 2020
View reviewed changes
Copy link
Member

@mweinelt mweinelt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@Mic92 Mic92 merged commit 15c1ac7 into NixOS:master Jun 23, 2020
@Mic92 Mic92 deleted the hass branch June 23, 2020 00:18
@Mic92
Copy link
Member Author

Mic92 commented Jun 23, 2020

@mweinelt should I add you to maintainers in home-assistant?

@mweinelt
Copy link
Member

mweinelt commented Jun 23, 2020 via email

Mic92 added a commit to Mic92/nixpkgs that referenced this pull request Jun 23, 2020
@Mic92
home-assistant: add hexa as maintainers
da196d2 
NixOS#91273 (comment)
@Mic92 Mic92 mentioned this pull request Jun 23, 2020
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mweinelt mweinelt mweinelt approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Mic92 @mweinelt