Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

solr: 8.4.1 -> 8.6.1 [20.03 backport] #96881

Merged
merged 4 commits into from
Nov 5, 2020
Merged

solr: 8.4.1 -> 8.6.1 [20.03 backport] #96881

merged 4 commits into from
Nov 5, 2020

Conversation

aanderse
Copy link
Member

@aanderse aanderse commented Sep 1, 2020

Motivation for this change

CVE-2020-13941 - resolves #96813.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@r-ryantm @aanderse
solr: 8.4.1 -> 8.5.0
fd70277 
(cherry picked from commit 7613ae0)
@r-ryantm @aanderse
solr: 8.5.0 -> 8.5.1
dc6333c 
(cherry picked from commit f82006b)
@r-ryantm @aanderse
solr: 8.5.1 -> 8.5.2
7a4bae9 
(cherry picked from commit 41a81c4)
@r-ryantm @aanderse
solr: 8.5.2 -> 8.6.1
977ee46 
(cherry picked from commit 563b73d)
@aanderse aanderse added the 8.has: port to stable A PR already has a backport to the stable release. label Sep 1, 2020
@ofborg ofborg bot requested a review from domenkozar September 1, 2020 01:14
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Sep 1, 2020
@risicle
Copy link
Contributor

risicle commented Sep 2, 2020

It does look like this is only exploitable on windows...

@stigtsp stigtsp added the 1.severity: security Issues which raise a security issue, or PRs that fix one label Sep 25, 2020
@mweinelt
Copy link
Member

mweinelt commented Nov 4, 2020

No, I believe this also applies to Windows.

apache/lucene-solr#1572
apache/lucene-solr#1629
apache/lucene-solr#1641

@mweinelt
Copy link
Member

mweinelt commented Nov 4, 2020

I'm not entirely sure how to test this. Debian ignores this issue and classifies it as minor.

Result of nixpkgs-review pr 96881 1

1 package built:
  • solr (solr_7 ,solr_8)

@aanderse
Copy link
Member Author

aanderse commented Nov 5, 2020

@GrahamcOfBorg test solr
🤷‍♂️

@mweinelt mweinelt merged commit 9ec0d8c into NixOS:release-20.03 Nov 5, 2020
@aanderse aanderse deleted the solr-backport branch November 5, 2020 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mweinelt mweinelt mweinelt approved these changes

@domenkozar domenkozar Awaiting requested review from domenkozar

Assignees
No one assigned
Labels
1.severity: security Issues which raise a security issue, or PRs that fix one 8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@aanderse @risicle @mweinelt @stigtsp @r-ryantm