handle read-only files #89
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes an issue mentioned in nixpkgs: NixOS/nixpkgs#14440
|
Arguably, if files are read-only, they are read-only for a reason, so programs should not chmod them on their own. Instead it should be the user's responsibility to make the file writable first. |
|
Good point. That's also how it was fixed in the .nix file. |
|
I'll close this PR, okay? |
rpurdie
pushed a commit
to yoctoproject/poky
that referenced
this pull request
Aug 14, 2022
…ss tweak This was the original reason to add the patch: https://git.openembedded.org/openembedded-core/commit/?id=18efcbcb896239c64fedd009ce57f3f0c668cbc0 and this is the upstream discussion which suggests handling read-only files explicitly outside of patchelf: NixOS/patchelf#89 (From OE-Core rev: 728775c) Signed-off-by: Alexander Kanavin <alex@linutronix.de> Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
halstead
pushed a commit
to openembedded/openembedded-core
that referenced
this pull request
Aug 14, 2022
…ss tweak This was the original reason to add the patch: https://git.openembedded.org/openembedded-core/commit/?id=18efcbcb896239c64fedd009ce57f3f0c668cbc0 and this is the upstream discussion which suggests handling read-only files explicitly outside of patchelf: NixOS/patchelf#89 Signed-off-by: Alexander Kanavin <alex@linutronix.de> Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
rpurdie
pushed a commit
to yoctoproject/poky
that referenced
this pull request
Apr 11, 2023
…ss tweak This was the original reason to add the patch: https://git.openembedded.org/openembedded-core/commit/?id=18efcbcb896239c64fedd009ce57f3f0c668cbc0 and this is the upstream discussion which suggests handling read-only files explicitly outside of patchelf: NixOS/patchelf#89 (From OE-Core rev: 163e2d5defebab262a5ec6fa9885deedace538f2) Signed-off-by: Alexander Kanavin <alex@linutronix.de> Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org> Signed-off-by: Steve Sakoman <steve@sakoman.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
halstead
pushed a commit
to openembedded/openembedded-core
that referenced
this pull request
Apr 11, 2023
…ss tweak This was the original reason to add the patch: https://git.openembedded.org/openembedded-core/commit/?id=18efcbcb896239c64fedd009ce57f3f0c668cbc0 and this is the upstream discussion which suggests handling read-only files explicitly outside of patchelf: NixOS/patchelf#89 Signed-off-by: Alexander Kanavin <alex@linutronix.de> Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org> Signed-off-by: Steve Sakoman <steve@sakoman.com>
jpuhlman
pushed a commit
to MontaVista-OpenSourceTechnology/poky
that referenced
this pull request
Apr 19, 2023
…ss tweak Source: poky MR: 124663 Type: Integration Disposition: Merged from poky ChangeID: 312dfcc Description: This was the original reason to add the patch: https://git.openembedded.org/openembedded-core/commit/?id=18efcbcb896239c64fedd009ce57f3f0c668cbc0 and this is the upstream discussion which suggests handling read-only files explicitly outside of patchelf: NixOS/patchelf#89 (From OE-Core rev: 163e2d5defebab262a5ec6fa9885deedace538f2) Signed-off-by: Alexander Kanavin <alex@linutronix.de> Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org> Signed-off-by: Steve Sakoman <steve@sakoman.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org> Signed-off-by: Jeremy A. Puhlman <jpuhlman@mvista.com>
halstead
pushed a commit
to openembedded/openembedded-core
that referenced
this pull request
Jun 27, 2023
We are seeing autobuilder failures with the latest uninative: patchelf: open: Permission denied See upstream discussion which suggests handling read-only files explicitly outside of patchelf: NixOS/patchelf#89 Signed-off-by: Steve Sakoman <steve@sakoman.com>
halstead
pushed a commit
to yoctoproject/poky
that referenced
this pull request
Jun 27, 2023
We are seeing autobuilder failures with the latest uninative: patchelf: open: Permission denied See upstream discussion which suggests handling read-only files explicitly outside of patchelf: NixOS/patchelf#89 (From OE-Core rev: 3680fcbf9ba327aedb32bb4eb647dd56fcccfd51) Signed-off-by: Steve Sakoman <steve@sakoman.com>
jpuhlman
pushed a commit
to MontaVista-OpenSourceTechnology/poky
that referenced
this pull request
Jun 30, 2023
Source: poky MR: 125762 Type: Integration Disposition: Merged from poky ChangeID: 756bae9bf901474c1bb98d1b5603d22591652e21 Description: We are seeing autobuilder failures with the latest uninative: patchelf: open: Permission denied See upstream discussion which suggests handling read-only files explicitly outside of patchelf: NixOS/patchelf#89 (From OE-Core rev: 3680fcbf9ba327aedb32bb4eb647dd56fcccfd51) Signed-off-by: Steve Sakoman <steve@sakoman.com> Signed-off-by: Jeremy A. Puhlman <jpuhlman@mvista.com>
daregit
pushed a commit
to daregit/yocto-combined
that referenced
this pull request
May 22, 2024
…ive.bbclass tweak This was the original reason to add the patch: https://git.openembedded.org/openembedded-core/commit/?id=18efcbcb896239c64fedd009ce57f3f0c668cbc0 and this is the upstream discussion which suggests handling read-only files explicitly outside of patchelf: NixOS/patchelf#89 (From OE-Core rev: 728775c87a7e35a03408675ce1c7a8cd061b2fda) Signed-off-by: Alexander Kanavin <alex@linutronix.de> Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
daregit
pushed a commit
to daregit/yocto-combined
that referenced
this pull request
May 22, 2024
…ive.bbclass tweak This was the original reason to add the patch: https://git.openembedded.org/openembedded-core/commit/?id=18efcbcb896239c64fedd009ce57f3f0c668cbc0 and this is the upstream discussion which suggests handling read-only files explicitly outside of patchelf: NixOS/patchelf#89 (From OE-Core rev: 728775c87a7e35a03408675ce1c7a8cd061b2fda) Signed-off-by: Alexander Kanavin <alex@linutronix.de> Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue mentioned in nixpkgs: NixOS/nixpkgs#14440