Type safety improvements #10
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
The sample app has also been migrated to demonstrate usage. |
sylwester-zielinski
approved these changes
Oct 26, 2022
app/src/main/java/no/nordicsemi/android/common/test/main/page/BasicViewsPage.kt
Outdated
Show resolved
Hide resolved
navigation/src/main/java/no/nordicsemi/android/common/navigation/Navigator.kt
Outdated
Show resolved
Hide resolved
Pap36
approved these changes
Oct 26, 2022
Contributor
Pap36
left a comment
Pap36
left a comment
There was a problem hiding this comment.
Looking forward to Blinky migrating training.
himalia416
approved these changes
Oct 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the following changes, some of which are braking:
NavigationDestinationsclass removed in favour ofList<NavigationDestination>.SimpleNavigationViewModeladded for easy cases when only basic navigation is to be used.NavigationResultobjects withCancelledorSuccessoptions.