Add support for external_object_instance from github.com #219
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Adding a commit to handle Mention 🎉:
I have worked with a single component (like Let me know, Thanks! |
transitive-bullshit
requested changes
Mar 17, 2022
Member
transitive-bullshit
left a comment
transitive-bullshit
left a comment
There was a problem hiding this comment.
This is an awesome set of changes @julbrs. Really great work.
Just a few minor nits and it's good-to-go.
packages/react-notion-x/src/components/external-component-github.tsx
Outdated
Show resolved
Hide resolved
Contributor
Author
|
Hi @transitive-bullshit 👋 Thanks for the review, I have added a commit with the suggested modification: e514502 I have also found some additional places to use Let me know if you find anything else, |
transitive-bullshit
approved these changes
Mar 17, 2022
| const blockId = decorator[1] | ||
| const externalObjectInstance = recordMap.block[blockId] | ||
| ?.value as ExternalObjectInstance | ||
| switch (externalObjectInstance.format?.domain) { |
Member
There was a problem hiding this comment.
externalObjectInstance may be undefined here
Member
|
Awesome work; thanks @julbrs 🙏 Hoping to get a maintenance update out soon which should include this change. |
Member
|
Published in |
julbrs
added a commit
to julbrs/julbrs-portfolio
that referenced
this pull request
Mar 17, 2022
* to get advantage of NotionX/react-notion-x#219 !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
The goal of this PR is to fix #216 for
github.comlinks only. It's the Preview mode, not the Mention mode (still need to work on it!)Here is an exemple page that contains this block: https://julb.notion.site/How-it-s-built-4ad0d992a4614b83854eff2fff616de6
It looks like that on notion:
It looks like that on react-notion-x with this PR:
Dark Mode:
Some infos:
owner/name) and no update date.Let me know if you need additional input!
Thanks!