fix: 🐛 add missing property cover #368
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
futantan
changed the title
Collaborator
|
@futantan, thanks for this. Could you add a test page id where you are seeing an issue with this? Where are you needing the cover type? |
Contributor
Author
|
@normdoow For every pages which is a database, the cover property is the cover image url. |
normdoow
reviewed
Oct 10, 2022
| copied_from: string | ||
| template_pages?: Array<ID> | ||
|
|
||
| cover?: string; |
Collaborator
There was a problem hiding this comment.
Looks like you are just adding the cover type. More work probably needs to be done to add this in code.
Contributor
Author
|
Not needed. The data is already there from notion’s api
…On Tue, Oct 11, 2022 at 00:01 Noah Bragg ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In packages/notion-types/src/collection.ts
<#368 (comment)>
:
> @@ -39,6 +39,7 @@ export interface Collection {
copied_from: string
template_pages?: Array<ID>
+ cover?: string;
Looks like you are just adding the cover type. More work probably needs to
be done to add this in code.
—
Reply to this email directly, view it on GitHub
<#368 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABP2MGJ5DUS6OA2HMB2RM6DWCQ4W5ANCNFSM6AAAAAAQH33DSQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Notion Test Page ID