Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
…tures - Introduced `ContentEditableController` to manage content editable states. - Registered `ContentEditableController` in core features and store. - Updated `Lifecycle` to synchronize content editable state during focus recovery. - Removed readOnly handling from `TextSpan` components in React and Vue, allowing for dynamic content editing.
…troller - Moved the `this.sync()` call to the beginning of the `enable` method to ensure synchronization occurs immediately when the controller is enabled. - Updated tests in `Base.spec.tsx` and `slots.spec.tsx` to check for the presence of elements and their attributes more reliably, improving test accuracy.
|
Deployment failed with the following error: Learn More: https://vercel.com/nowelys-projects?upgradeToPro=build-rate-limit |
- Eliminated redundant declaration of `tokens` in the `useCoreFeatures` hook to streamline the code. - Ensured that the `tokens` variable is only defined once, improving readability and maintainability.
|
Deployment failed with the following error: Learn More: https://vercel.com/nowelys-projects?upgradeToPro=build-rate-limit |
…casting - Removed redundant type casting for `slots` and `slotProps` in `TextSpan.vue`, enhancing code clarity and maintainability. - Streamlined the component's setup by directly using the store's state without additional type assertions.
Nowely
pushed a commit
that referenced
this pull request
Mar 7, 2026
🤖 I have created a release *beep* *boop* --- ## [0.5.0](0.4.0...0.5.0) (2026-03-07) ### Features * **core:** add ContentEditableController for DOM-based editing ([#134](#134)) ([633133b](633133b)) ### Refactoring * extract shared logic from framework adapters to core ([#145](#145)) ([795c0e8](795c0e8)) * improve Signal typing with interface augmentation for framework-specific use() return types ([#143](#143)) ([e6d4efc](e6d4efc)) ### Miscellaneous * migrate to pnpm catalog for centralized dependency management ([#140](#140)) ([b71cd55](b71cd55)) * update oxlint configuration ([#144](#144)) ([1db73ec](1db73ec)) ### Tests * add comprehensive Vue component tests with Vitest ([#142](#142)) ([231f3dc](231f3dc)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ContentEditableControllerto managecontenteditableDOM behavior as a dedicated core featurecoreFeaturesandLifecyclefor proper initialization/syncuseCoreFeatureshookTextSpanin both React and Vue to reflect the new controller integration