Skip to content

Use sets instead of arrays when importing data #210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 30, 2023
Merged

Use sets instead of arrays when importing data #210

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions lib/tasks/cards.rake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -213,7 +213,7 @@ namespace :cards do
# We don't reload JSON files in here because we have already saved all the cards
# with their subtypes fields and can parse from there.
def import_card_subtypes(cards)
card_id_to_subtype_id = []
card_id_to_subtype_id = Set.new
cards.each { |c|
next if c["subtypes"].nil?
c["subtypes"].each do |st|
Expand Down Expand Up @@ -405,7 +405,7 @@ namespace :cards do
end

def import_card_pool_card_cycles(card_pools)
card_pool_id_to_cycle_id = []
card_pool_id_to_cycle_id = Set.new

# Collect each card pool's cycles
card_pools.each do |p|
Expand Down Expand Up @@ -443,7 +443,7 @@ namespace :cards do
end

def import_card_pool_card_sets(card_pools)
card_pool_id_to_set_id = []
card_pool_id_to_set_id = Set.new

# Get implied sets from cycles in the card_pool
ActiveRecord::Base.connection.execute('SELECT card_pool_id, id FROM card_pools_card_cycles r INNER JOIN card_sets AS s ON r.card_cycle_id = s.card_cycle_id').each do |s|
Expand Down Expand Up @@ -486,7 +486,7 @@ namespace :cards do
end

def import_card_pool_cards(card_pools)
card_pool_id_to_card_id = []
card_pool_id_to_card_id = Set.new

# Get implied cards from sets in the card_pool
ActiveRecord::Base.connection.execute('SELECT card_pool_id, card_id FROM card_pools_card_sets AS r INNER JOIN printings AS p ON r.card_set_id = p.card_set_id GROUP BY 1,2').each do |s|
Expand Down