Skip to content

Conversation

leukosaima
Copy link
Contributor

@leukosaima leukosaima commented Feb 1, 2024

Workflow to push to DO registry, docker-compose that uses the netrunner-cards-json container

Copy link

codecov bot commented Feb 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4baa0f8) 96.75% compared to head (91d66e5) 96.75%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #228   +/-   ##
=======================================
  Coverage   96.75%   96.75%           
=======================================
  Files          54       54           
  Lines         771      771           
  Branches      185      185           
=======================================
  Hits          746      746           
  Misses         25       25           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@leukosaima leukosaima marked this pull request as ready for review February 2, 2024 02:21
@leukosaima leukosaima requested a review from plural February 3, 2024 12:43
Copy link
Contributor

@plural plural left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please set your editor to add newlines to your files on save. Several of this are missing them.

i'm going to try this out in a bit

@leukosaima leukosaima merged commit c793884 into main Feb 3, 2024
@leukosaima leukosaima deleted the json-container branch February 3, 2024 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants