initial changes for supporting pronouns for cards #238
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #238 +/- ##
=======================================
Coverage 96.75% 96.75%
=======================================
Files 54 54
Lines 771 771
Branches 185 185
=======================================
Hits 746 746
Misses 25 25 ☔ View full report in Codecov by Sentry. |
plural
reviewed
Mar 6, 2024
There was a problem hiding this comment.
you should also add the attribute to the printings resource.
plural
reviewed
Mar 7, 2024
| attributes :format_ids, :card_pool_ids, :snapshot_ids | ||
| attributes :card_cycle_ids, :card_set_ids, :attribution | ||
| attributes :released_by, :printings_released_by, :designed_by | ||
| attributes :released_by, :printings_released_by, :designed_by, :pronouns |
There was a problem hiding this comment.
optional, but consider adding a filter for it as well.
plural
approved these changes
Mar 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.