Skip to content

Add most recent printing images to card #395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 24, 2025
Merged

Add most recent printing images to card #395

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2f05d65
Add latest_printing_images field
migueldlr Jun 23, 2025
c7dd13d
Add missing images function
migueldlr Jun 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions app/resources/card_resource.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,9 @@ class CardResource < ApplicationResource # rubocop:disable Metrics/ClassLength
attribute :card_abilities, :hash
attribute :restrictions, :hash
attribute :latest_printing_id, :string
attribute :latest_printing_images, :hash do
images(@object.latest_printing_id)
end

filter :card_cycle_id, :string do
eq do |scope, value|
Expand Down Expand Up @@ -157,4 +160,20 @@ class CardResource < ApplicationResource # rubocop:disable Metrics/ClassLength
end

many_to_many :card_pools

private

def images(id, face_index = nil)
url_prefix = Rails.configuration.x.printing_images.nrdb_classic_prefix
face_suffix = "-#{face_index}" unless face_index.nil?
{
'nrdb_classic' => {
'tiny' => "#{url_prefix}/tiny/#{id}#{face_suffix}.jpg",
'small' => "#{url_prefix}/small/#{id}#{face_suffix}.jpg",
'medium' => "#{url_prefix}/medium/#{id}#{face_suffix}.jpg",
'large' => "#{url_prefix}/large/#{id}#{face_suffix}.jpg",
'narrative' => "#{url_prefix}/large/#{id}#{face_suffix}-narrative.jpg"
}
}
end
end
2 changes: 2 additions & 0 deletions spec/resources/card_resource_reads_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,8 @@
expect(data.influence_limit).to eq(card.influence_limit)
expect(data.is_unique).to eq(card.is_unique)
expect(data.latest_printing_id).to eq(card.latest_printing_id)
expect(data.latest_printing_images).not_to be_nil
expect(data.latest_printing_images['nrdb_classic']).to include('tiny', 'small', 'medium', 'large')
expect(data.memory_cost).to eq(card.memory_cost)
expect(data.minimum_deck_size).to eq(card.minimum_deck_size)
expect(data.num_printings).to eq(card.num_printings)
Expand Down