Skip to content

Initial api relationships #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 19, 2022
Merged

Initial api relationships #4

merged 2 commits into from
Feb 19, 2022

Conversation

plural
Copy link
Contributor

@plural plural commented Feb 14, 2022

No description provided.

@plural plural requested a review from NoahTheDuke February 14, 2022 06:16
NoahTheDuke
NoahTheDuke approved these changes Feb 14, 2022
View reviewed changes
Copy link

@NoahTheDuke NoahTheDuke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These has_many are just for json:api right? Already defined for the models themselves? If so, g2g

@plural
Copy link
Contributor Author

plural commented Feb 19, 2022

Yes. These are in addition to the model relationships, which is a bit annoying.

@plural plural merged commit 6403af3 into main Feb 19, 2022
@NoahTheDuke NoahTheDuke deleted the initial-api-relationships branch February 21, 2022 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@NoahTheDuke NoahTheDuke NoahTheDuke approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@plural @NoahTheDuke