Fix importer for renamed card_cycle_ids and card_set_ids fields. #66
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
distributive
approved these changes
Jul 3, 2022
NoahTheDuke
reviewed
Jul 3, 2022
| card_pools.each do |p| | ||
| next if p['cycles'].nil? | ||
| p['cycles'].each do |s| | ||
| next if p['card_cycle_ids'].nil? |
There was a problem hiding this comment.
Outside of this pr, can you use dot syntax for these accesses?
There was a problem hiding this comment.
sure. i'll do a cleanup CL. Is there anything gained aside from -3 characters per access?
There was a problem hiding this comment.
Preface: I don't exactly remember the details so take this with a grain of salt.
That being said, I don't think so and it doesn't actually matter so you don't have to change over if you don't want to. It was something I had to do when the properties used dashes instead of underscores and now that they're underscores you can use dot syntax, but like javascript, they're equivalent so don't do extra work if you don't wanna.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.