fixed composer.json with broken datatable asset dependency #33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Hello, thanks for PR. |
|
Hi, the assets in "class DataTableAsset" link to "datatables-plugins" , but the real bower assets are in "datatables.net-plugins". I could make it work with the custom assets manager , but the default should work out of the box. |
Contributor
|
@Droktor did you check links from my previous comment? |
|
@ZAYEC77 , yes I did before posting, if I'm not mistaken an issue was corrected 21 days ago. I just installed the extension around 5 days ago. so it should contain the corrected version ? |
Contributor
|
@Droktor, seems like this PR is actual. Thanks. |
|
@ZAYEC77 Thanks for your effort. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.