fix: add empty string to valid severities #143
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathanlam
force-pushed
the
fix--add-empty-string-to-valid-severities
branch
from
180284a to
626e5b7
Compare
jonathanlam
force-pushed
the
fix--add-empty-string-to-valid-severities
branch
from
65e3d1c to
2f7898c
Compare
andsnw
approved these changes
Dec 29, 2024
tim-thacker-nullify
approved these changes
Dec 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
there is a bug where the empty string and other valid config files are coming up as invalid. this behaviour is also inconsistent with the comment
isValid := validator.ValidateConfig(parsedConfig)returns falseChecklist
patch,minor,majororno-releaselabels