Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MIG] website_apps_store: Migration to 12.0 #61

Merged
merged 35 commits into from
May 23, 2019
Merged

[MIG] website_apps_store: Migration to 12.0 #61

merged 35 commits into from
May 23, 2019

Conversation

victormmtorres
Copy link

@oca-clabot

This comment has been minimized.

Sign in to view
@pedrobaeza
Copy link
Member

@victormmtorres it seems there's something strange in your commit email address. Please check for CLA, and both runbot and Travis are red.

@pedrobaeza pedrobaeza added this to the 12.0 milestone Apr 30, 2019
@OCA-git-bot OCA-git-bot mentioned this pull request Apr 30, 2019
Closed
3 tasks
@victormmtorres victormmtorres mentioned this pull request May 2, 2019
Closed
umiphos
umiphos reviewed May 5, 2019
View reviewed changes
website_apps_store/models/product_template.py Outdated

def get_author_details(self):
author_ids = []
for variant in self.product_variant_ids:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you try:

Suggested change
for variant in self.product_variant_ids:
author_ids = variant in self.mapped('product_variant_ids.app_author_ids').ids

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not exactly... it should be directly:

return self.mapped('product_variant_ids.app_author_ids')

@bizzappdev bizzappdev mentioned this pull request May 6, 2019
Closed
@bizzappdev
Copy link

@victormmtorres one fix has been added in v11.
please also include those fix in v12
#64

@pedrobaeza
Copy link
Member

@victormmtorres check also runbot and Travis status

Divya Modi and others added 21 commits May 6, 2019 12:15
[WIP]partial commit for migration of apps-store
6b6230f
[FIX]small changes
7df4bed
[FIX]remove console from js file
86cbe07
[FIX]remove coding from files
b14dada
[FIX]correct version number
bf22533
[FIX] Changes as per suggested
15ab731
[FIX] add changes as per requested
4ed7cb4
[FIX] remove phantomjs for download zip file
edd238d
[FIX] made changes as per suggested
b591d0a
@bizzappdev
[FIX]Proper path for the phantomjs
1714a02
@oca-travis
[UPD] Update website_apps_store.pot
1f35b54
@StephanRozendaal
[IMP] Show a default 'OCA' icon on product
692dff0 
When the related module has no icon, show a default 'OCA' icon
from the static path.
@oscarolar
[IMP] website_apps_store: improved download button (OCA#16)
1d8c030
@bizzappdev
[FIX] download file name Fix (OCA#18)
e212a28
@bizzappdev
11.0 Improvement for filters and product page description (OCA#14)
693a96f 
* [IMP] website_apps_store: remove author filter from shop

* [FIX]apps_product_creator: fix the broken image path problem with github direct link

* [FIX]rename method with proper name

* [FIX] solve the problem for renaming function

* [FIX] reoved the author test cases
@oscarolar
[IMP] apps-store (OCA#15)
a59fe37 
* [IMP] apps-store:

- Shop:
  * Removed filter by author.
  * Added a more informative placeholder to the searchbox
  * Added categories of apps to public categories.
  * Added a filter `All` option for categories dropdown.
  * Removed sort by price.

- Changed the way products are created, now products are related
to their correspondant category. (used the ones from Odoo.com/apps)

- On PDP added the version of the app if it has no variants.

* [REF] if no category found will defailt to 'Other' category
@StephanRozendaal
[IMP] Fix overflow on repository URL
cf33587 
Fix the overflow in the repository URL on the product shop page.
@oscarolar
[ADD] website_apps_store: App maturity filter to the shop.
c4fd98f
@oscarolar
[ADD] website_apps_store: new PDP layout. (OCA#23)
882244f
@StephanRozendaal
[REF] Remove some whitespace
074c3de 
Remove some whitespace.
@StephanRozendaal
[IMP] Remove shop product qweb changes
4501225 
Remove qweb changes that are made to the product image in the
webshop, because they are no longer needed (a default image is
set on each product now).
bizzappdev and others added 13 commits May 6, 2019 12:20
@bizzappdev
update products attributes and create attribute values (OCA#40)
db03d32 
* [FIX]update the product for the new version

* [FIX]max version problem and also rewrite logic so the from fronend if the version is not selected manually then the default(with less sequence) will be downloaded

* [IMP]added technical name search functionality

* change version number

* [IMP]Merged create and update product cron job

* [FIX]fix variable names
@bizzappdev
Fix Bad rendering of links inside README (OCA#42)
61394e1 
* [FIX][OCA#37]fix rendering from README

* [ADD]added CONTRIBUTORS

* [FIX] Sorting problem. sorted(for getting default version) as similar as it is sorted from website view
@bizzappdev
[FIX]visibility for the selected options and filters improvements (OC…
db7d217 
…A#43)

* [FIX]visibility for the selection options and do not loss the selection option when we change filter from maturity to version etc.

* [VER]Added Version number
@bizzappdev
[FIX]CSS module description
9c9bfac
@bizzappdev
[FIX]website_apps_store: fix the shop pager
a601f25
@bizzappdev
[FIX][49] solve pager with search parameter (OCA#51)
09488cc
@bizzappdev
Sort by Download and rating (OCA#46)
0b7774c 
* [WIP] added initial support for Google recaptcha

* [WIP]added dependencies

* [IMP]Added google captcha with download functionality with reset and validation

* [IMP]added download count fields and increament it when donwloaded

* [ADD]added missing files

* [IMP]website_apps_store: add sort by download count on website

* remove console and not extra space

* [VER]changed version number

* [FIX]website_apps_store: fix test case error

* [FIX]reset only if google recaptcha is initiated
@bizzappdev
11.0 issue OCA#50 add the module technical name in front page (OCA#52)
6698a23 
* [FIX][49] solve pager with search parameter

* [IMP]website_apps_store : add technical name in front page

* [IMP]website_apps_store : add website tour to search technical name

* [FIX]website_apps_store : add demo/product_template_demo.xml in menifest.py
@bizzappdev
[FIX] website product page event not define problem
b2bec31
@bizzappdev
[FIX]fix 403 public user error
990d884
@bizzappdev
[FIX]website_apps_store: attribute value change was not changing the …
8b2bdd1 
…href for the repository. OCA#56
@OCA-git-bot
[ADD] icon.png
eb1bd7f
@oscarolar
[FIX] webstie_apps_store: Icon sizes are now consistent
37b153d
@victormmtorres victormmtorres force-pushed the 12.0-mig-website_apps_store branch 3 times, most recently from cd8b6ab to 04dce07 Compare May 6, 2019 13:14
@victormmtorres
Copy link
Author

I've include #64 and missed dependencies hope Travis and Runbot pass

@victormmtorres
Copy link
Author

Changes done @pedrobaeza

MiquelRForgeFlow
MiquelRForgeFlow approved these changes May 21, 2019
View reviewed changes
Copy link

@MiquelRForgeFlow MiquelRForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code review 👍

(although I don't understand the changes in test_website_apps_store.py)

pedrobaeza
pedrobaeza approved these changes May 23, 2019
View reviewed changes
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's move on as this module is inherited from others, but should work.

@pedrobaeza pedrobaeza merged commit 02e01fd into OCA:12.0 May 23, 2019
@pedrobaeza pedrobaeza deleted the 12.0-mig-website_apps_store branch May 23, 2019 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tardo Tardo Tardo left review comments

@umiphos umiphos umiphos left review comments

@pedrobaeza pedrobaeza pedrobaeza approved these changes

@MiquelRForgeFlow MiquelRForgeFlow MiquelRForgeFlow approved these changes

Assignees
No one assigned
Labels
approved
Projects
None yet
Milestone
12.0
Development

Successfully merging this pull request may close these issues.

None yet