feat: 🎸 Set up route with gcloud store for list studies#1069
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1069 +/- ##
==========================================
+ Coverage 9.59% 13.61% +4.01%
==========================================
Files 251 154 -97
Lines 6273 4371 -1902
Branches 1170 888 -282
==========================================
- Hits 602 595 -7
+ Misses 4608 2994 -1614
+ Partials 1063 782 -281
Continue to review full report at Codecov.
|
swederik
reviewed
Oct 22, 2019
swederik
reviewed
Oct 22, 2019
* ci: first attempt at adding a gated docker PR Publish (#1038) * ci: first attempt at adding a gated docker PR Publish * See if we can use contexts to inject variables after approval * fix build command * try alternative context * docs: pull request template that spells out PR checklist * change context back to Docker Hub * Switch optional approval to another workflow * Make docker builds faster * Update .github/PULL_REQUEST_TEMPLATE/pull_request_template.md
fixes broken build
- @ohif/extension-vtk@0.52.14 - @ohif/ui@0.56.0 - @ohif/viewer@1.11.0
- @ohif/viewer@1.11.1
- @ohif/extension-vtk@0.52.15 - @ohif/viewer@1.11.2
- @ohif/extension-vtk@0.52.16 - @ohif/viewer@1.11.3
swederik
reviewed
Oct 25, 2019
| All notable changes to this project will be documented in this file. | ||
| See [Conventional Commits](https://conventionalcommits.org) for commit guidelines. | ||
|
|
||
|
|
Member
There was a problem hiding this comment.
Why is your PR even changing this file? Remove this.
swederik
reviewed
Oct 25, 2019
|
|
||
| const newServer = urlBasedServers[0]; | ||
|
|
||
| let exists = _.some(servers, server => { |
Member
There was a problem hiding this comment.
es6 Arrays can do this already, so you can remove Lodash for this: https://youmightnotneed.com/lodash/#some
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Includes
Closes
#1056