Skip to content

fix: CineDialog buttons label#998

Merged
dannyrb merged 3 commits into
masterfrom
issue-995
Oct 4, 2019
Merged

fix: CineDialog buttons label#998
dannyrb merged 3 commits into
masterfrom
issue-995

Conversation

@rodrigoea

Copy link
Copy Markdown
Contributor

Fixes #995

@rodrigoea rodrigoea self-assigned this Oct 4, 2019
@dannyrb dannyrb requested a review from swederik October 4, 2019 15:21
@codecov

codecov Bot commented Oct 4, 2019

Copy link
Copy Markdown

Codecov Report

Merging #998 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #998   +/-   ##
======================================
  Coverage    9.71%   9.71%           
======================================
  Files         240     240           
  Lines        5991    5991           
  Branches     1121    1121           
======================================
  Hits          582     582           
  Misses       4392    4392           
  Partials     1017    1017
Flag Coverage Δ
#core 13.47% <ø> (ø) ⬆️
#viewer 0.51% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e064fd3...e149497. Read the comment docs.

"Play / Stop": "$t(Common:Play) / $t(Common:Stop)",
"Previous image": "$t(Common:Previous) $t(Common:Image)",
"Skip to first image": "Skip to first $t(Common:Image)",
"Skip to last image": "Skip, to last $t(Common:Image)",

@swederik swederik Oct 4, 2019

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do not change this file, we need to change it in Locize. You can remove these changes from the PR:

// Note: The index.js files inside src/locales are dynamically generated

@dannyrb

dannyrb commented Oct 4, 2019

Copy link
Copy Markdown
Member

Steps to update translation mappings:

image

image

  • Click the OHIF project
  • Find the target language en-US (our reference language)
    • Click "CineDialog" under our language
    • Update values/mappings
    • Click Save
  • Pull updated language files using Locize API

See:
Viewers/platform/i18n/pullTranslations.sh: Here

The .locize configuration file is not checked into source code (so we don't leak our API key). Here is the shape of the configuration file:

I'm sending you an invitation to locize so you can access our Project's API key and do these edits. I think only @swederik has done this end-to-end so far. Let me know if you encounter issues and I can assist.

@rodrigoea

Copy link
Copy Markdown
Contributor Author

@swederik @dannyrb Now, all changes were pulled from Locize

@dannyrb

dannyrb commented Oct 4, 2019

Copy link
Copy Markdown
Member

hi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CINE control buttons with wrong titles

3 participants