Skip to content

Conversation

@jimwashbrook-ons
Copy link
Contributor

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update

What

  • Adds values to DatasetType and DatasetState enums for not set values (NOT_SET)
  • Defaults the places where those enums are used to NOT_SET

Testing

Have any new tests been added as part of this issue? If not, try to explain why test coverage is not needed here.

  • Yes
  • No
    Please write a brief description of why test coverage is not necessary here.
  • Not as part of this ticket. (Could be done at a later point)

Documentation

Has any new documentation been written as part of this issue? We should try to keep documentation up to date
as new code is added, rather than leaving it for the future.

  • Yes
  • No
    Please write a brief description of why documentation is not necessary here.
  • Not as part of this ticket. (Could be done at a later point)

Related issues

Provide links to any related issues.

How to review

Describe the steps required to test the changes.

@jimwashbrook-ons jimwashbrook-ons requested a review from a team as a code owner June 10, 2025 13:57
@jimwashbrook-ons jimwashbrook-ons force-pushed the feat/3360/default-enum-values branch from 4ca3f9e to a5dd59b Compare June 10, 2025 13:59
Copy link
Contributor

@SarahJohnsonONS SarahJohnsonONS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jimwashbrook-ons jimwashbrook-ons force-pushed the feat/3360/default-enum-values branch from a5dd59b to d26aa9c Compare June 10, 2025 14:11
@jimwashbrook-ons jimwashbrook-ons merged commit d26aa9c into develop Jun 10, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants