Skip to content
This repository was archived by the owner on Apr 2, 2024. It is now read-only.

Conversation

@rimi-itk
Copy link
Collaborator

@rimi-itk rimi-itk commented Feb 4, 2022

This will allow installing release candidates (given "minimum-stability": "dev").

We need this fix: https://git.drupalcode.org/project/maestro/-/commit/02763844737baad476a300ebdfa95939559fb25c.

This will allow installing release candidates (given `"minimum-stability": "dev"`).
@rimi-itk rimi-itk requested a review from madsnorgaard February 4, 2022 11:10
Copy link
Collaborator

@madsnorgaard madsnorgaard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice change and I agree with it.

@madsnorgaard madsnorgaard merged commit b5bc116 into develop Feb 4, 2022
@madsnorgaard
Copy link
Collaborator

madsnorgaard commented Feb 4, 2022

It seems the actual change we need has not yet been tagged, see: https://git.drupalcode.org/project/maestro/-/compare/3.0.1-rc2...3.0.1-rc3?from_project_id=59423

So this change will not do anything in terms of fixing the error before a 3.0.1-rc4, major or minor release has been created for the drupal/maestro module.

Thoughts @rimi-itk

@rimi-itk
Copy link
Collaborator Author

rimi-itk commented Feb 4, 2022

You're absolutely right, @madsnorgaard. I've added

"drupal/maestro": "dev-3.x as 3.0.1-rc2"

to our project composer.json so we actually get https://git.drupalcode.org/project/maestro/-/tree/3.x.

But in general I think we should use ^ versions in our dependencies rather than fixed versions.

@rimi-itk rimi-itk deleted the rimi-itk-patch-1 branch February 4, 2022 12:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants