This repository was archived by the owner on Apr 2, 2024. It is now read-only.
OS2FORMS-371 Added easy access to assigned maestro task by token #131
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rimi-itk
approved these changes
Apr 5, 2022
andriyun
changed the title
rimi-itk
suggested changes
May 2, 2022
Collaborator
rimi-itk
left a comment
rimi-itk
left a comment
There was a problem hiding this comment.
Looks good. === should be used for comparisons rather than just ==.
os2forms_forloeb.module
Outdated
| function os2forms_forloeb_entity_access(\Drupal\Core\Entity\EntityInterface $entity, $operation, \Drupal\Core\Session\AccountInterface $account) { | ||
| if ($operation == 'update' && $entity instanceof WebformSubmission) { | ||
| $token = \Drupal::request()->query->get('os2forms-forloeb-ws-token'); | ||
| if ($token && $token == $entity->getToken()) { |
Collaborator
There was a problem hiding this comment.
For consistency, we should always use === for comparison.
| // Catch os2forms-forloeb access token and pass it further. | ||
| if ($form instanceof RedirectResponse && $token = \Drupal::request()->query->get('os2forms-forloeb-ws-token')) { | ||
| // Check token to previous submission and update it to new one. | ||
| if ($token == $webform_submission->getToken()) { |
Contributor
Author
|
@rimi-itk I can not go further with it. |
Collaborator
|
Hmm … I cannot merge either, @andriyun. @mBoegvald & @madsnorgaard, can you help us out? |
Collaborator
|
I will squash and merge. Hope you are all well! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup for PR130