This repository was archived by the owner on Apr 2, 2024. It is now read-only.
Adding WIP webforms and Maestro templates. #26
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agger-magenta
approved these changes
Apr 14, 2021
Contributor
agger-magenta
left a comment
agger-magenta
left a comment
There was a problem hiding this comment.
Ja, lad os endelig få de eksempler ind!
lats1
suggested changes
Apr 15, 2021
os2forms_forloeb.module
Outdated
Comment on lines
57
to
67
| // $form['approve_content'] = array( | ||
| // '#id' => 'approve_content', | ||
| // '#type' => 'radios', | ||
| // '#options' => array( | ||
| // 0 => t("Assign for Review"), | ||
| // 1 => t("Approve") | ||
| // ), | ||
| // '#default_value' => 0, | ||
| // '#title' => t('Review or Approve Content '), | ||
| // '#required' => true, | ||
| // ); |
Contributor
There was a problem hiding this comment.
Is there a reason for why this commented code is present? Should it be removed? A comment for why it's still there would be helpful.
Collaborator
Author
There was a problem hiding this comment.
This code has been removed as it is not necessary for the review workflow.
| '#markup' => t('Select a Content Item.'), | ||
| ); | ||
|
|
||
| $content_type_options = array(""=>"All Content Types"); |
Contributor
There was a problem hiding this comment.
I guess an empty string as key in an array will work, but why not use "all" or something similar for better understanding? And also, should "All Content Types" be translated?
Collaborator
Author
There was a problem hiding this comment.
Changes committed per comment. All good input.
lats1
approved these changes
Apr 20, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.