Skip to content
This repository was archived by the owner on Apr 2, 2024. It is now read-only.

Conversation

@madsnorgaard
Copy link
Collaborator

Testing Travis CI can pass with fixes per Codesniffer report.

@andriyun
Copy link
Contributor

andriyun commented May 6, 2021

Looks good for me.

I found something that is not related to this PR. But need to be fixed in next phases.
Buy some reason drupal-check didn't catch deprecation function usage https://github.com/OS2Forms/os2forms_forloeb/blob/fix_comments_plus_indentation/os2forms_forloeb.module#L97

And this related for all modules where drupal-check is using to check deprecation usage.

@madsnorgaard
Copy link
Collaborator Author

Looks good for me.

I found something that is not related to this PR. But need to be fixed in next phases.
Buy some reason drupal-check didn't catch deprecation function usage https://github.com/OS2Forms/os2forms_forloeb/blob/fix_comments_plus_indentation/os2forms_forloeb.module#L97

And this related for all modules where drupal-check is using to check deprecation usage.

I have handled the deprecation notice per your review, thus the CI check passed. It was straightforward getting Travis to run. Great review and focus on high code quality.

@madsnorgaard madsnorgaard merged commit af874c1 into add_automated_ci_checks_to_project May 6, 2021
@andriyun andriyun deleted the fix_comments_plus_indentation branch May 6, 2021 14:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants