-
Notifications
You must be signed in to change notification settings - Fork 1
Remove custom_theme dependency #87
Conversation
|
@lats1 Dette er en del af Magentas tilrettelser til brugergrænsefladen - specifikt ved at ebnytte Gin fremfor custom_theme. Dettte skal sikre kontinuitet og at vi kan tilrette felter/formualrer til også at overholde de fælles design principper uden at benytte custom_theme. |
madsnorgaard
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
Isn't this more suited for the profile? @madsnorgaard And haven't we talked about moving gin as dependency to the profile instead of the module? |
I am currently testing this. May I suggest, then, that this module sets neither |
|
Absolutely! |
|
@madsnorgaard @lats1 I (think I) removed everything related to theme configuration from this module. Can you please re-review and verify that I didn't remove too much? |
… shouldn't make decisions about which theme to use. Leave that up to whichever install profile is being used.
6434470 to
6fbfd75
Compare
What it says on the tin. Removes
custom_themedependency so that the module can be used in projects that don't have that theme. Sets default theme to Gin instead.