Skip to content
This repository was archived by the owner on Apr 2, 2024. It is now read-only.

Conversation

@madsnorgaard
Copy link
Collaborator

@madsnorgaard madsnorgaard commented Nov 3, 2021

This is a refactor of the following:

"drupal/rules": "3.0.0-alpha6",
"drupal/rules_token": "1.2.0",
"drupal/rules_webform": "1.5.0",
"os2forms/os2forms_forloeb_profile": "^1.0",

Rules is being refactored as it is currently breaking all our pipelines and builds. OS2forms Forløb Profile is removed as a dependency from the module to have the dependency go one way only.

@lats1
Copy link
Contributor

lats1 commented Nov 5, 2021

It totally makes sense about the profile dependency. But I think I need some more information about the rules dependencies...

Are there use cases which needs these modules? If that is so, and they can't be on this module, should they be somewhere else?

Is there anything else somewhere that needs these modules?

Is it because you want to make things D9 compatible? If so, isn't there versions of the modules which is D9 compatible?

@madsnorgaard
Copy link
Collaborator Author

It totally makes sense about the profile dependency. But I think I need some more information about the rules dependencies...
Yes, this is a good change in terms of profile/module dynamic.

Are there use cases which needs these modules? If that is so, and they can't be on this module, should they be somewhere else?
No, there are no use case at present as we have handling purge of data using Webform modules builtin functionality-

Is there anything else somewhere that needs these modules?
Not from my review of the context of the module.

Is it because you want to make things D9 compatible? If so, isn't there versions of the modules which is D9 compatible?
It is mainly to keep the D8 build and our pipeline in a healthy state. Right now non of us would be able to build the production ready environment.

@agger-magenta agger-magenta merged commit bed9310 into develop Nov 5, 2021
@madsnorgaard madsnorgaard deleted the remove_rules_modules_from_forloeb branch January 20, 2022 14:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants