Implemented application table column selection #149
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…operly from gateway fetches
augusthjerrild
requested changes
Dec 1, 2023
Contributor
augusthjerrild
left a comment
augusthjerrild
left a comment
There was a problem hiding this comment.
The task has these requirements which are not met right now:
IoT-devices should be sortable.
Datatargets should be sortable.
Futhermore two observations:
- When logged out, the customized table is turned into default again. Is this intended :-)?
- The button for choosing the desired table headers only registers mouseclick if it's on the text. If clicked on the white area around the text, nothing happens. Is this intended? And should it be fixed? :-)
src/app/applications/applications-list/applications-table/applications-table.component.ts
Show resolved
Hide resolved
src/app/applications/applications-list/applications-table/applications-table.component.ts
Show resolved
Hide resolved
src/app/applications/applications-list/applications-table/applications-table.component.html
Show resolved
Hide resolved
Base automatically changed from
feature/IOT-1379-Lock-name-column-on-gateways-status
to
stage
December 5, 2023 07:55
fcv-iteratorIt
deleted the
feature/IOT-1403-toggleable-columns-applications-table
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.