IOT-46: Time limited access #202
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
augusthjerrild
requested changes
May 30, 2025
Contributor
augusthjerrild
left a comment
augusthjerrild
left a comment
There was a problem hiding this comment.
I might have misunderstood it. But if i give my user an expire date from 2 days ago, i would expect that the user could not login. Right now that is possible. It might be an issue in the backend :)
src/app/admin/api-key/api-key-list/api-key-table/api-key-table.component.html
Show resolved
Hide resolved
augusthjerrild
approved these changes
Jun 12, 2025
Contributor
augusthjerrild
left a comment
augusthjerrild
left a comment
There was a problem hiding this comment.
Really nice.
Only thing I observe, is, that if a user has been deactivated because the date is expired, and i then change the deactivationDate to something later, then it still stands as deactivated. I think I would expect the user to be activated again. Instead I have to do it manually. It might be fine, but this is an observation and we might consider what should be the best solution :-)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.