Skip to content

Conversation

@notZaki
Copy link
Member

@notZaki notZaki commented Jan 31, 2023

An attempt to have the code contribution table appear on the website. Will update/close depending on how the preview looks.

@netlify
Copy link

netlify bot commented Jan 31, 2023

Deploy Preview for osipicodecollection ready!

Name Link
🔨 Latest commit 0c2bfb0
🔍 Latest deploy log https://app.netlify.com/sites/osipicodecollection/deploys/63d991c28b2693000978559a
😎 Deploy Preview https://deploy-preview-122--osipicodecollection.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@codecov
Copy link

codecov bot commented Jan 31, 2023

Codecov Report

Merging #122 (0c2bfb0) into develop (bd0f285) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop     #122   +/-   ##
========================================
  Coverage    64.75%   64.75%           
========================================
  Files           64       64           
  Lines         3476     3476           
========================================
  Hits          2251     2251           
  Misses        1225     1225           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@notZaki
Copy link
Member Author

notZaki commented Feb 8, 2023

So this is a preview of the new table. It will appear on the website if this PR is merged.
This would act as a replacement to this table in the repo

I suppose the advantage of this PR is that:

  • The table joins with everything on the website, rather than being separate on the repo
  • GitHub actions will no longer create new commits whenever the csv is updated
    • I don't think there was anything wrong with this, but actions that commit into the same repository that triggers them (and runs on all branches/forks) are scary to me

This isn't a high priority change, so it can be closed or merged whenever there's time to review to the PR.

@stadmill
Copy link
Collaborator

stadmill commented Feb 9, 2023

Looks good. It makes sense to have the list on the website rather than the repo. Thanks Zaki!

@stadmill stadmill closed this Feb 9, 2023
@stadmill stadmill reopened this Feb 9, 2023
@stadmill stadmill merged commit 2355244 into OSIPI:develop Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants