-
Notifications
You must be signed in to change notification settings - Fork 13
Reimplement using GStreamer and Rust #5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a7969be
to
e99c565
Compare
da1bef1
to
2ef5a61
Compare
800a3cf
to
2a61425
Compare
The idea is to toy with the GStreamer use as a way to render the boot animation. This reduces a lot of platform specific code we have to handle and offer nice possibilities such as audio use during the boot process. Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
028c8bc
to
ee5124d
Compare
A parser for the animation structure is included. It does the bare minimum but is capable of parse the provided manifest. Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
Jonathas-Conceicao
suggested changes
Jun 24, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some suggestions
@Jonathas-Conceicao please review the PR again. |
An animation example is now provided, as well as the respective script required to convert it to the valid archive. Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
This is currently supporting the playback but does not yet is capable of interrupting it. Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
Jonathas-Conceicao
approved these changes
Jun 24, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reimplements the EasySplash using GStreamer as backend. This is the first preview and likely will be changed prior it is released.
To run this, you can use:
and to send commands to interrupt the animation (current animation is not interruptable) you can use: