Skip to content

Conversation

@synopse
Copy link
Contributor

@synopse synopse commented Mar 21, 2024

  • please check the README.md information

Arnaud Bouchez added 2 commits March 21, 2024 17:19
- please check the README.md information
@gcarreno
Copy link
Collaborator

gcarreno commented Mar 22, 2024

Hey Arnaud(@synopse),

This is an awesome entry!!
First of all it ticks some admin niceties:

  • It drops the binary in the proper place( Just the name needs adjustment )
  • It has a Release build mode

Thanks for that!!

I only ask 3 things:

  • The first heading of the README.md should contain your name: Arnaud Bouchez
  • The folder name for the entry should be named abouchez
  • The binary should be named abouchez

Apart from that, this is a solid entry.

Cheers,
Gus

@gcarreno
Copy link
Collaborator

Hey Arnaud(@synopse),

Installed mORMot2 from stable 2.2 release.

Now just waiting for your corrections.

Will add you to the entries.json file to make you entry part of the rotation.

Cheers,
Gus

@synopse
Copy link
Contributor Author

synopse commented Mar 22, 2024

Done as requested.

@gcarreno
Copy link
Collaborator

Hey Arnaud(@synopse),

Awesome sauce, thanks !!

Merging and testing.

I'll post preliminary results on your discussion, that I'll create once I've got some data for it.

Cheers,
Gus

@gcarreno gcarreno merged commit b726ad2 into ObjectPascal-Community:main Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants