abouchez/mormot: noticeable performance boost #39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
synopse
commented
Mar 22, 2024
synopse
commented
- in fact, the Station[] array was not 64-bytes aligned, so the L1 CPU cache access was suboptimal
- timing went from around 4.2s to 4.0s on my laptop (5% improvement)
- we could expect better scaling too with multiple threads on the Benchmark hardware, because L3 shared cache should be less polluted
added 2 commits
March 22, 2024 10:18
- in fact, the Station[] array was not 64-bytes aligned, so the L1 CPU cache access was suboptimal - timing went from around 4.2s to 4.0s on my laptop (5% improvement) - we could expect better scaling too with multiple threads, because L3 shared cache should be less polluted
Collaborator
|
Hey Arnaud(@synopse), Can you also update this PR with a correction to the issues I mention on your discussion? Thanks!! Cheers, |
Collaborator
|
Hey Arnaud(@synopse), Never mind, I shoulda looked at your commit 😄 Merging!! Cheers, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.