This repository was archived by the owner on Jul 3, 2023. It is now read-only.
Add Dockerfiles for CloudKitty #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aimbot31
force-pushed
the
dockerfiles-cloudkitty
branch
3 times, most recently
from
b123706 to
f17fdf4
Compare
Member
Author
|
@lukapeschke i think it should be good now |
lukapeschke
suggested changes
Aug 1, 2019
Contributor
lukapeschke
left a comment
lukapeschke
left a comment
There was a problem hiding this comment.
A few remarks on the Dockerfiles and the README, see inline comments
README.md
Outdated
|
|
||
| ### api | ||
|
|
||
| Contains the Dockerfiles for the api side of CloudKitty and its dependencies. |
Contributor
There was a problem hiding this comment.
"the Dockerfile", no S. "For CloudKitty's API": api side sounds a bit french 😉
README.md
Outdated
|
|
||
| ### processor | ||
|
|
||
| Contains the Dockerfiles for the processor side of CloudKitty. |
Contributor
There was a problem hiding this comment.
Same remarks a for the API.
CloudKitty/api/Dockerfile
Outdated
|
|
||
| RUN pip install cloudkitty | ||
|
|
||
| RUN apt-get purge -y \ |
Contributor
There was a problem hiding this comment.
Please merge the three RUN instructions above into one.
CloudKitty/api/Dockerfile
Outdated
|
|
||
| COPY apache_cloudkitty.conf /etc/apache2/sites-available/cloudkitty.conf | ||
|
|
||
| RUN a2ensite cloudkitty |
Contributor
There was a problem hiding this comment.
Hmm maybe this could be done by directly copying the cloudkitty.conf file to sites-enabled ?
CloudKitty/api/Dockerfile
Outdated
|
|
||
| RUN a2ensite cloudkitty | ||
|
|
||
| ADD run_apache.sh /root/run_apache.sh |
Added the Dockerfile for CloudKitty api and its dependencies. Also added the Dockerfile for CloudKitty processor and updated the README to include the Dockerfiles documentation.
aimbot31
force-pushed
the
dockerfiles-cloudkitty
branch
from
f17fdf4 to
25aeeb9
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the Dockerfile for CloudKitty api and its dependencies.
Also added the Dockerfile for CloudKitty processor
and updated the README to include the Dockerfiles documentation.